Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eligibility + Docs: U.S. not US #2481

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Eligibility + Docs: U.S. not US #2481

merged 4 commits into from
Oct 29, 2024

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Oct 28, 2024

closes #2476

VA and other federal government sites use U.S. not US. We are aligning that copy style to our own site, starting with the actual user-facing site, and also with the docs:

https://design.va.gov/content-style-guide/word-list#u

image

No changes for Spanish language.

Updates doc for U.S.: https://benefits-2481--cal-itp-previews.netlify.app/product-and-design/copy-style/#terms

@machikoyasuda machikoyasuda self-assigned this Oct 28, 2024
@machikoyasuda machikoyasuda requested a review from a team as a code owner October 28, 2024 23:17
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework front-end HTML/CSS/JavaScript and Django templates documentation [auto] Improvements or additions to documentation labels Oct 28, 2024
@machikoyasuda machikoyasuda changed the title Fix: U.S. not US Eligibility + Docs: U.S. not US Oct 28, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

US Veteran also appears in the fixtures, can you please update that?

@machikoyasuda
Copy link
Member Author

@thekaveman Updated

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🇺🇸 🫡

@machikoyasuda machikoyasuda merged commit 8d32516 into main Oct 29, 2024
12 checks passed
@machikoyasuda machikoyasuda deleted the feat/2476-u.s.-veteran branch October 29, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev documentation [auto] Improvements or additions to documentation front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eligibility page: Change "US Veteran" to "U.S. Veteran"
2 participants