Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eligibility page: Remove Login.gov modal trigger sentence #2482

Closed
wants to merge 4 commits into from
Closed

Eligibility page: Remove Login.gov modal trigger sentence #2482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc186ee
feat(eligibility): remove Login.gov sentence from Calfresh, Senior, V…
machikoyasuda Oct 29, 2024
87a77ff
feat(eligibility): Remove Login.gov modal + copy
machikoyasuda Oct 29, 2024
e484bbf
feat(modal): remove Login modal trigger code
machikoyasuda Oct 29, 2024
cf5b28f
fix(copy): bring back image alt tag
machikoyasuda Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benefits/core/templates/core/includes/modal-trigger.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- Inline link to trigger modal -->
{# djlint:off #}
<a href="#{{ modal }}" class="{{ classes }}" data-bs-toggle="modal" data-bs-target="#{{ modal }}">{{ text }}{% if login %}<span class="fallback-text color-logo">Login.gov</span>{% endif %}</a>{% if period %}.{% endif %}
<a href="#{{ modal }}" class="{{ classes }}" data-bs-toggle="modal" data-bs-target="#{{ modal }}">{{ text }}</a>{% if period %}.{% endif %}
{# djlint:on #}
40 changes: 0 additions & 40 deletions benefits/eligibility/templates/eligibility/includes/modal--login-gov-help.html
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions benefits/eligibility/templates/eligibility/includes/selection-label--calfresh.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
{% include "core/includes/modal-trigger.html" with modal="modal--calfresh" text=calfresh_modal_link period=True %}
{% include "eligibility/includes/modal--calfresh.html" with id="modal--calfresh" size="modal-lg" header="p-md-2 p-3" body="pb-md-3 mb-md-3 mx-md-3 py-0 pt-0 absolute-top" %}

{% translate "This transit benefit will remain active for one year. You will need to verify your identity with" %}
{% include "core/includes/modal-trigger.html" with classes="border-0 bg-transparent p-0 login" modal="modal--login-gov-veteran" login=True period=True %}
{% include "eligibility/includes/modal--login-gov-help.html" with id="modal--login-gov-calfresh" size="modal-lg" header="p-md-2 p-3" body="pb-md-3 mb-md-3 mx-md-3 py-0 pt-0 absolute-top" %}
{% translate "This transit benefit will remain active for one year." %}

{% endblock description %}
6 changes: 1 addition & 5 deletions benefits/eligibility/templates/eligibility/includes/selection-label--senior.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,5 @@
{% endblock label %}

{% block description %}
{% translate "You must be 65 years or older. You will need to verify your identity with" %}

{% include "core/includes/modal-trigger.html" with classes="border-0 bg-transparent p-0 login" modal="modal--login-gov" login=True period=True %}

{% include "eligibility/includes/modal--login-gov-help.html" with id="modal--login-gov" size="modal-lg" header="p-md-2 p-3" body="pb-md-3 mb-md-3 mx-md-3 py-0 pt-0 absolute-top" %}
{% translate "You must be 65 years or older." %}
{% endblock description %}
7 changes: 1 addition & 6 deletions benefits/eligibility/templates/eligibility/includes/selection-label--veteran.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@

{% block description %}
{% blocktranslate trimmed %}
This option is for people who have served in the active military, naval, or air service, and who were discharged or released therefrom under conditions other than dishonorable. You will need to verify your identity with
This option is for people who have served in the active military, naval, or air service, and who were discharged or released therefrom under conditions other than dishonorable.
{% endblocktranslate %}

{% include "core/includes/modal-trigger.html" with classes="border-0 bg-transparent p-0 login" modal="modal--login-gov-veteran" login=True period=True %}

{% include "eligibility/includes/modal--login-gov-help.html" with id="modal--login-gov-veteran" size="modal-lg" header="p-md-2 p-3" body="pb-md-3 mb-md-3 mx-md-3 py-0 pt-0 absolute-top" %}

{% endblock description %}
16 changes: 5 additions & 11 deletions benefits/locale/en/LC_MESSAGES/django.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
msgid ""
msgstr ""
"Report-Msgid-Bugs-To: https://github.com/cal-itp/benefits/issues \n"
"POT-Creation-Date: 2024-10-28 16:14-0700\n"
"POT-Creation-Date: 2024-10-29 11:20-0700\n"
"Language: English\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
Expand Down Expand Up @@ -498,16 +498,13 @@ msgstr ""
msgid "Go back"
msgstr ""

msgid "Learn more about"
msgid "Verify your identity with "
msgstr ""

msgctxt "image alt text"
msgid "Login.gov"
msgstr ""

msgid "Verify your identity with "
msgstr ""

msgid ""
"We use Login.gov to verify your identity to make sure you are eligible for "
"the transit benefit you selected."
Expand All @@ -525,9 +522,7 @@ msgstr ""
msgid "recently received CalFresh funds"
msgstr ""

msgid ""
"This transit benefit will remain active for one year. You will need to "
"verify your identity with"
msgid "This transit benefit will remain active for one year."
msgstr ""

msgid "Agency Card"
Expand Down Expand Up @@ -566,8 +561,7 @@ msgstr ""
msgid "Older Adult"
msgstr ""

msgid ""
"You must be 65 years or older. You will need to verify your identity with"
msgid "You must be 65 years or older."
msgstr ""

msgid "U.S. Veteran"
Expand All @@ -576,7 +570,7 @@ msgstr ""
msgid ""
"This option is for people who have served in the active military, naval, or "
"air service, and who were discharged or released therefrom under conditions "
"other than dishonorable. You will need to verify your identity with"
"other than dishonorable."
msgstr ""

#, python-format
Expand Down
26 changes: 9 additions & 17 deletions benefits/locale/es/LC_MESSAGES/django.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
msgid ""
msgstr ""
"Report-Msgid-Bugs-To: https://github.com/cal-itp/benefits/issues \n"
"POT-Creation-Date: 2024-10-28 16:14-0700\n"
"POT-Creation-Date: 2024-10-29 11:20-0700\n"
"Language: Español\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
Expand Down Expand Up @@ -648,16 +648,13 @@ msgstr ""
msgid "Go back"
msgstr "Volver"

msgid "Learn more about"
msgstr "Más información sobre"
msgid "Verify your identity with "
msgstr "Verifique su identidad con "

msgctxt "image alt text"
msgid "Login.gov"
msgstr "Login.gov"

msgid "Verify your identity with "
msgstr "Verifique su identidad con "

msgid ""
"We use Login.gov to verify your identity to make sure you are eligible for "
"the transit benefit you selected."
Expand All @@ -678,12 +675,8 @@ msgstr "Debe haber"
msgid "recently received CalFresh funds"
msgstr "recibido fondos de CalFresh recientemente"

msgid ""
"This transit benefit will remain active for one year. You will need to "
"verify your identity with"
msgstr ""
"Este beneficio de tránsito permanecerá activo por un año. Necesitará "
"verificar su identidad con"
msgid "This transit benefit will remain active for one year."
msgstr "Este beneficio de tránsito permanecerá activo por un año."

msgid "Agency Card"
msgstr "Tarjeta de agencia"
Expand Down Expand Up @@ -727,21 +720,20 @@ msgstr ""
msgid "Older Adult"
msgstr "Adulto mayor"

msgid ""
"You must be 65 years or older. You will need to verify your identity with"
msgstr "Debe tener 65 años o más. Deberá verificar su identidad con"
msgid "You must be 65 years or older."
msgstr "Debe tener 65 años o más."

msgid "U.S. Veteran"
msgstr "Veterano de EE. UU."

msgid ""
"This option is for people who have served in the active military, naval, or "
"air service, and who were discharged or released therefrom under conditions "
"other than dishonorable. You will need to verify your identity with"
"other than dishonorable."
msgstr ""
"Esta opción es para personas que hayan prestado servicio militar, naval o "
"aéreo de manera activa, y quienes fueron dados de baja o liberados en "
"condiciones que no hayan sido deshonrosas. Deberá verificar su identidad con"
"condiciones que no hayan sido deshonrosas."

#, python-format
msgid ""
Expand Down
Loading