Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eligibility page: Use Agency Cardholder, not Agency Card #2486

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Eligibility page: Use Agency Cardholder, not Agency Card #2486

merged 1 commit into from
Oct 31, 2024

Conversation

machikoyasuda
Copy link
Member

closes #2477

image image

@machikoyasuda machikoyasuda requested a review from a team as a code owner October 29, 2024 20:31
@machikoyasuda machikoyasuda self-assigned this Oct 29, 2024
@github-actions github-actions bot added migrations [auto] Review for potential model changes/needed data migrations updates i18n Copy: Language files or Django i18n framework deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates and removed i18n Copy: Language files or Django i18n framework labels Oct 29, 2024
@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

thekaveman
thekaveman reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is at least one other page that uses Agency Card in the title and copy: start--cst-agency-card.

Should it be updated here as well? This would align with e.g. You selected a CalFresh/Medicare Cardholder transit benefit on other pages.

@machikoyasuda
Copy link
Member Author

@thekaveman I thought about this too. This one is tricky because each agency's card name is different:

Courtesy Card
Reduced Fare Mobility ID

And so we'd have to change these to Reduced Fare Mobility ID Cardholder and then Courtesy Cardholder? Courtesy Card Cardholder? Seems like a bigger discussion.

Ultimately this PR is just a really small fix that only affects CST's Agency Card option.

@thekaveman thekaveman merged commit 3d17fac into main Oct 31, 2024
15 checks passed
@thekaveman thekaveman deleted the feat/2477-agency-cardholder branch October 31, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates migrations [auto] Review for potential model changes/needed data migrations updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eligibility page: Change "Agency Card" to "Agency Cardholder"
2 participants
@machikoyasuda @thekaveman