Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: web perf - load recaptcha script only where it's needed #2631

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

angela-tran
Copy link
Member

Part of #2493

This PR moves the loading of the reCAPTCHA script to only where it's actually used. This is a small change that belongs to the category of Identify inline Javascript that doesn't need to be on every page.

@angela-tran angela-tran self-assigned this Jan 16, 2025
@angela-tran angela-tran requested a review from a team as a code owner January 16, 2025 19:32
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Jan 16, 2025
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Besides performance reasons, it's nice that the script is now next to the rest of the reCAPTCHA template code.

@angela-tran angela-tran merged commit afc03f0 into main Jan 17, 2025
12 checks passed
@angela-tran angela-tran deleted the refactor/move-recaptcha-script branch January 17, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants