Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap gtfs_funnel vp preprocessing with fct_vehicle_locations_grouped #1392

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

tiffanychu90
Copy link
Member

@tiffanychu90 tiffanychu90 commented Feb 20, 2025

gtfs_funnel

stop_times

  • notebook recommendation: since we can't actually get a trip_instance_key from scheduled trips table, we can only dedupe for now.
    • This only affects 1 operator, Victor Valley GMV, 2 routes, and 8 trips. Deduping leaves us with 4 trips, and we will have to drop 4 trips, since they have a first trip arrival (based on stop_times) that's not found in fct_scheduled_trips
  • Backfill 2025 dates, since it was Dec refactor where the sorting was removed. git blame myself for this commit, so only going forward do we need to overwrite files
  • Add logs
  • Resolves Bug: stop_times_with_direction: use trip's start time for join dim_stop_times with fct_scheduled_trips #1385

vehicle positions

segment_speed_utils

  • Allow sorting to be done within creating vp linestring

Copy link

nbviewer URLs for impacted notebooks:

1 similar comment
Copy link

nbviewer URLs for impacted notebooks:

Copy link

nbviewer URLs for impacted notebooks:

Copy link

nbviewer URLs for impacted notebooks:

3 similar comments
Copy link

nbviewer URLs for impacted notebooks:

Copy link

nbviewer URLs for impacted notebooks:

Copy link

nbviewer URLs for impacted notebooks:

@tiffanychu90 tiffanychu90 merged commit 13d33a2 into main Feb 20, 2025
6 checks passed
@tiffanychu90 tiffanychu90 deleted the funnel-swap branch February 20, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: stop_times_with_direction: use trip's start time for join dim_stop_times with fct_scheduled_trips
1 participant