-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap gtfs_funnel
vp preprocessing with fct_vehicle_locations_grouped
#1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbviewer URLs for impacted notebooks: |
1 similar comment
nbviewer URLs for impacted notebooks: |
2 tasks
nbviewer URLs for impacted notebooks: |
nbviewer URLs for impacted notebooks: |
3 similar comments
nbviewer URLs for impacted notebooks: |
nbviewer URLs for impacted notebooks: |
nbviewer URLs for impacted notebooks: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gtfs_funnel
stop_times
trip_instance_key
from scheduled trips table, we can only dedupe for now.first trip arrival
(based onstop_times
) that's not found infct_scheduled_trips
git blame
myself for this commit, so only going forward do we need to overwrite filesstop_times_with_direction
: use trip's start time for joindim_stop_times
withfct_scheduled_trips
#1385vehicle positions
mart_gtfs
table is created - use this as our new upstream starting point ingtfs_funnel
mart_gtfs.fct_vehicle_locations_grouped
data-infra#3660mart_gtfs.fct_vehicle_locations_grouped
- incremental settings likefct_vehicle_locations
data-infra#3672gtfs_funnel/Makefile
and removevp_keep_usable.py
,cleanup.py
, andvp_dwell_time.py
dwell_sec
column that is not in the mart table, if we need it, we should create itsegment_speed_utils