Skip to content

Update dask versions in calitp-data-analysis #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2024
Merged

Update dask versions in calitp-data-analysis #3362

merged 1 commit into from
May 28, 2024

Conversation

vevetron
Copy link
Contributor

@vevetron vevetron commented May 28, 2024 •
edited
Loading

Description

  • This is part of the upgrade from python 3.9 to python 3.11.6
  • This is so when building jupyter-single-user-image, the dask packages match and everything builds.

continues work on #3352

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

poetry lock
poetry install

Post-merge follow-ups

  • No action required
  • Actions required (specified below)
    When deployed we need to test things.

@vevetron vevetron requested a review from tiffanychu90 May 28, 2024 19:26
tiffanychu90
tiffanychu90 requested changes May 28, 2024
View reviewed changes
Copy link
Member

@tiffanychu90 tiffanychu90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super small comment - I think the convention is to use date for version, so instead of 2024-5-24b, it would just be 2024-5-28 for today?

@vevetron vevetron force-pushed the upgrade-calitip-data-analysis-package-dask branch from 54c1dc4 to da69c01 Compare May 28, 2024 21:02
@vevetron vevetron requested a review from tiffanychu90 May 28, 2024 21:03
tiffanychu90
tiffanychu90 approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@tiffanychu90 tiffanychu90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for upgrading!

@vevetron vevetron merged commit df3dbb8 into main May 28, 2024
@vevetron vevetron deleted the upgrade-calitip-data-analysis-package-dask branch May 28, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffanychu90 tiffanychu90 tiffanychu90 approved these changes

@hunterowens hunterowens Awaiting requested review from hunterowens

@evansiroky evansiroky Awaiting requested review from evansiroky evansiroky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vevetron @tiffanychu90