Refine GTFS-RT validator error messaging #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohrite
requested review from
erikamov
and removed request for
evansiroky and
vevetron
erikamov
approved these changes
Nov 26, 2024
Signed-off-by: Erika Pacheco <erika@ministryofvelocity.com>
ohrite
force-pushed
the
mov/2780-gtfs-rt-validation-binary
branch
from
e00d16e to
a069890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a better message when GTFS-RT validator jar skips a file. Previously, the
validation_exceptionlogged was a raw byte string representing the MD5 of a file evaluated by the gtfs-realtime-validator jar file.This has been amended to print the message "No validator output" instead, mirroring the command line output.
Resolves #2780
Type of change
How has this been tested?
Tested locally.
Post-merge follow-ups
Monitor
cal-itp-data-infra.staging.int_gtfs_quality__rt_validation_outcomesto ensure that friendly error messages appear rather than byte strings.