Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTD: materialize marts as tables and add handling for report_year field #3603

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

charlie-costanzo
Copy link
Member

@charlie-costanzo charlie-costanzo commented Dec 18, 2024

Description

Following up in our MVP ingestion of NTD tables, this PR materializes our NTD mart data as tables and handles the report_year field as an integer in tables where relevant.

Type of change

  • New feature

How has this been tested?

Screenshot 2024-12-18 at 1 41 55 PM

Post-merge follow-ups

  • No action required

@charlie-costanzo charlie-costanzo added the data-pipeline-ingestion-and-modeling Ingesting, parsing and modeling data. Evan Siroky is product owner. label Dec 18, 2024
@charlie-costanzo charlie-costanzo self-assigned this Dec 18, 2024
Copy link

Warehouse report 📦

DAG

Legend (in order of precedence)

Resource type Indicator Resolution
Large table-materialized model Orange Make the model incremental
Large model without partitioning or clustering Orange Add partitioning and/or clustering
View with more than one child Yellow Materialize as a table or incremental
Incremental Light green
Table Green
View White

Copy link
Contributor

@erikamov erikamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@charlie-costanzo charlie-costanzo merged commit f81d512 into main Dec 18, 2024
4 checks passed
@charlie-costanzo charlie-costanzo deleted the ntd-year-and-materialization-handling branch December 18, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-pipeline-ingestion-and-modeling Ingesting, parsing and modeling data. Evan Siroky is product owner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants