Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[setting] Update setting style #78

Merged
merged 2 commits into from
Apr 5, 2024
Merged

[setting] Update setting style #78

merged 2 commits into from
Apr 5, 2024

Conversation

kylezryr
Copy link
Contributor

@kylezryr kylezryr commented Apr 2, 2024

What's new in this PR

  • Fixed styling of heading and subheading text in the settings page (this was already done by a previous PR)
  • Made the bottom tabs display when the user is on the settings page

Relevant Links

Notion Sprint Task

https://www.notion.so/calblueprint/setting-Update-setting-style-9213460b54b941ddafb40774105c94bb

Online sources

Related PRs

How to review

  • Go to the settings page from the home screen
  • Verify that the tabs display on the settings page and you can navigate from settings to the other tabs

Next steps

Tests Performed, Edge Cases

Screenshots

Screenshot 2024-04-02 at 16 24 15 jpeg

CC: @adityapawar1

@kylezryr kylezryr requested a review from adityapawar1 April 2, 2024 23:25
adityapawar1
adityapawar1 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@adityapawar1 adityapawar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! ready to merge

@adityapawar1 adityapawar1 merged commit 9a3d707 into main Apr 5, 2024
2 checks passed
@adityapawar1 adityapawar1 deleted the kyle/updateSettingsStyle branch April 5, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapawar1 adityapawar1 adityapawar1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylezryr @adityapawar1