-
-
Notifications
You must be signed in to change notification settings - Fork 7
style(pip): apply black, isort and lint fixes #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
calchiwo
commented
Feb 11, 2026
- Run black formatting
- Normalize import ordering with isort
- Apply ruff autofixes
- No functional changes
- Run black formatting - Normalize import ordering with isort - Apply ruff autofixes - No functional changes
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @calchiwo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing code quality and maintainability by standardizing the codebase's style and structure. It integrates automated formatting with Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request applies automated formatting and linting fixes, specifically adding newlines to explain_this_repo/cli.py and explain_this_repo/prompt.py to adhere to standard Python style conventions (PEP 8). While these changes improve code consistency, a security audit of the codebase revealed a significant vulnerability. The application is susceptible to Prompt Injection because it directly includes content from a target GitHub repository in the prompts sent to a Large Language Model without proper sanitization. This issue is exacerbated by a Path Traversal vulnerability in the repository parsing logic, which allows an attacker to specify an arbitrary repository, making the prompt injection easily exploitable and potentially leading to manipulated outputs from the language model.
| """.strip() | ||
|
|
||
| return prompt No newline at end of file | ||
| return prompt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function build_simple_prompt constructs a prompt for a Large Language Model (LLM) by directly embedding content fetched from a GitHub repository (readme, tree_text). This content is considered untrusted user input. A remote attacker can craft a malicious README file or source code within a repository that contains instructions to manipulate the LLM. When the application processes this malicious repository, these instructions are injected into the prompt, which could cause the LLM to ignore its original purpose, reveal sensitive information like its system prompt, or generate malicious content.
This is possible because the repository content is not sanitized before being included in the prompt. Furthermore, a path traversal vulnerability in explain_this_repo/cli.py allows an attacker to point the tool to an arbitrary, malicious repository, making this vulnerability easily exploitable.