-
-
Notifications
You must be signed in to change notification settings - Fork 6
fix(python): harden prompt isolation and centralize error handling #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -128,6 +128,26 @@ def run_doctor() -> int: | |||||||||||||||||||||
| return 0 if (ok1 and ok2) else 1 | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| def safe_read_repo_files(owner: str, repo: str): | ||||||||||||||||||||||
| try: | ||||||||||||||||||||||
| return read_repo_signal_files(owner, repo) | ||||||||||||||||||||||
| except Exception as e: | ||||||||||||||||||||||
| print(f"warning: could not read repository files: {e}") | ||||||||||||||||||||||
| return None | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| def generate_with_exit(prompt: str) -> str: | ||||||||||||||||||||||
| try: | ||||||||||||||||||||||
| return generate_explanation(prompt) | ||||||||||||||||||||||
| except Exception as e: | ||||||||||||||||||||||
| print("Failed to generate explanation.") | ||||||||||||||||||||||
| print(f"error: {e}") | ||||||||||||||||||||||
| print("\nfix:") | ||||||||||||||||||||||
| print("- Ensure GEMINI_API_KEY is set") | ||||||||||||||||||||||
| print("- Or run: explainthisrepo --doctor") | ||||||||||||||||||||||
|
Comment on lines
+143
to
+147
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Error messages and user guidance for fixing issues should be printed to
Suggested change
|
||||||||||||||||||||||
| raise SystemExit(1) | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| def main(): | ||||||||||||||||||||||
| parser = argparse.ArgumentParser( | ||||||||||||||||||||||
| prog="explainthisrepo", | ||||||||||||||||||||||
|
|
@@ -242,27 +262,15 @@ def main(): | |||||||||||||||||||||
|
|
||||||||||||||||||||||
| print("Generating explanation...") | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| try: | ||||||||||||||||||||||
| output = generate_explanation(prompt) | ||||||||||||||||||||||
| except Exception as e: | ||||||||||||||||||||||
| print("Failed to generate explanation.") | ||||||||||||||||||||||
| print(f"error: {e}") | ||||||||||||||||||||||
| print("\nfix:") | ||||||||||||||||||||||
| print("- Ensure GEMINI_API_KEY is set") | ||||||||||||||||||||||
| print("- Or run: explainthisrepo --doctor") | ||||||||||||||||||||||
| raise SystemExit(1) | ||||||||||||||||||||||
| output = generate_with_exit(prompt) | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| print("Quick summary 🎉") | ||||||||||||||||||||||
| print(output.strip()) | ||||||||||||||||||||||
| return | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| # SIMPLE MODE | ||||||||||||||||||||||
| if args.simple: | ||||||||||||||||||||||
| try: | ||||||||||||||||||||||
| read_result = read_repo_signal_files(owner, repo) | ||||||||||||||||||||||
| except Exception as e: | ||||||||||||||||||||||
| print(f"warning: could not read repository files: {e}") | ||||||||||||||||||||||
| read_result = None | ||||||||||||||||||||||
| read_result = safe_read_repo_files(owner, repo) | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| prompt = build_simple_prompt( | ||||||||||||||||||||||
| repo_name=repo_data.get("full_name"), | ||||||||||||||||||||||
|
|
@@ -273,26 +281,14 @@ def main(): | |||||||||||||||||||||
|
|
||||||||||||||||||||||
| print("Generating explanation...") | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| try: | ||||||||||||||||||||||
| output = generate_explanation(prompt) | ||||||||||||||||||||||
| except Exception as e: | ||||||||||||||||||||||
| print("Failed to generate explanation.") | ||||||||||||||||||||||
| print(f"error: {e}") | ||||||||||||||||||||||
| print("\nfix:") | ||||||||||||||||||||||
| print("- Ensure GEMINI_API_KEY is set") | ||||||||||||||||||||||
| print("- Or run: explainthisrepo --doctor") | ||||||||||||||||||||||
| raise SystemExit(1) | ||||||||||||||||||||||
| output = generate_with_exit(prompt) | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| print("Simple summary 🎉") | ||||||||||||||||||||||
| print(output.strip()) | ||||||||||||||||||||||
| return | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| # NORMAL / DETAILED MODE | ||||||||||||||||||||||
| try: | ||||||||||||||||||||||
| read_result = read_repo_signal_files(owner, repo) | ||||||||||||||||||||||
| except Exception as e: | ||||||||||||||||||||||
| print(f"warning: could not read repository files: {e}") | ||||||||||||||||||||||
| read_result = None | ||||||||||||||||||||||
| read_result = safe_read_repo_files(owner, repo) | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| prompt = build_prompt( | ||||||||||||||||||||||
| repo_name=repo_data.get("full_name"), | ||||||||||||||||||||||
|
|
@@ -305,15 +301,7 @@ def main(): | |||||||||||||||||||||
|
|
||||||||||||||||||||||
| print("Generating explanation...") | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| try: | ||||||||||||||||||||||
| output = generate_explanation(prompt) | ||||||||||||||||||||||
| except Exception as e: | ||||||||||||||||||||||
| print("Failed to generate explanation.") | ||||||||||||||||||||||
| print(f"error: {e}") | ||||||||||||||||||||||
| print("\nfix:") | ||||||||||||||||||||||
| print("- Ensure GEMINI_API_KEY is set") | ||||||||||||||||||||||
| print("- Or run: explainthisrepo --doctor") | ||||||||||||||||||||||
| raise SystemExit(1) | ||||||||||||||||||||||
| output = generate_with_exit(prompt) | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| print("Writing EXPLAIN.md...") | ||||||||||||||||||||||
| write_output(output) | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's standard practice for command-line tools to write warning messages to
stderr. This allows users to redirectstdout(the primary output) without losing important diagnostic messages. Please direct this warning tosys.stderr.