caps Download; thread-first aliases #259
Conversation
WalkthroughThis pull request introduces several updates across the Calcit project. The changes include version increments in Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (3)
- calcit/test-macro.cirru: Language not supported
- package.json: Language not supported
- src/cirru/calcit-core.cirru: Language not supported
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
README.md (4)
55-57: Clarify Default Behavior in Watch Mode Commands
The examples showingcr -1for single-run andcrfor watch mode are well presented. However, adding a brief comment that clarifies the fallback tocompact.cirrucould help new users.
77-78: JS Code Generation Commands Are Informative
The examples for generating JavaScript code clearly illustrate both the default behavior and the use of a custom output path. It might be beneficial to mention the default directory (js-out/) explicitly for clarity.
111-112: Refine Version Check Description for Clarity
The current phrase “:calcit-versionhelps in check version, and provides hints in CI environment” can be improved for clarity and grammatical correctness. Consider the following revision:-`:calcit-version` helps in check version, and provides hints in [CI](https://github.com/calcit-lang/setup-cr) environment. +`:calcit-version` assists in version checking and provides hints for CI environments.🧰 Tools
🪛 LanguageTool
[uncategorized] ~111-~111: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...ust dylibs.:calcit-versionhelps in check version, and provides hints in [CI](htt...(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
123-123: Adjust Grammar in Module Suffix Explanation
The sentence “Modules that ends with/s are automatically suffixedcompact.cirrusince it's the default entry.” contains a grammatical error. Consider revising it to:-Modules that ends with `/`s are automatically suffixed `compact.cirru` since it's the default entry. +Modules that end with `/` are automatically suffixed with `compact.cirru` as the default entry.This change improves subject–verb agreement and overall clarity.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~123-~123: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...les/memof/compact.cirru. Modules that ends with/s are automatically suffixedc...(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(3 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[uncategorized] ~59-~59: Did you mean: “By default,”?
Context: ...cr # watch mode enabled by default ``` By default Calcit reads :init-fn and `:reload-fn...
(BY_DEFAULT_COMMA)
[uncategorized] ~74-~74: A comma may be missing after the conjunctive/linking adverb ‘However’.
Context: ...Script and runs in consistet semantics. However it might require a lot of JavaScript in...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[uncategorized] ~111-~111: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...ust dylibs. :calcit-version helps in check version, and provides hints in [CI](htt...
(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
[uncategorized] ~123-~123: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...les/memof/compact.cirru. Modules that ends with /s are automatically suffixed c...
(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
🔇 Additional comments (6)
README.md (6)
47-47: Confirm New Alias Usage for Thread-first
The new example using thethread-firstalias is clearly demonstrated. Please double-check that the alias semantics align with the definitions incalcit-core.cirru.
63-63: Validate Custom Function Flag Syntax
The example demonstrating how to specify initialization and reload functions with--init-fnand--reload-fnlooks correct. Ensure that this syntax is documented elsewhere for consistency.
69-69: Entry Configuration Example Is Clear
Thecr --entry serverexample succinctly shows how to set the entry point when running Calcit. This example is straightforward and needs no further modification.
85-85: Verify JavaScript Entry Point Mapping
The snippet importing and invokingmain_$x_()properly reflects the mapping from Calcit'smain!function. Confirm that users are aware of the naming convention used during JavaScript codegen.
103-103: Update Dependency Version Information
The addition of:calcit-version |0.9.8in thedeps.cirruexample helps maintain version consistency across the documentation and configuration files (e.g.,Cargo.tomlandpackage.json). Please verify that all related files have been updated accordingly.
113-113: Module Loading Configuration Example Looks Good
The example for loading modules via the:modulesconfiguration is clear and useful. There is no further action required here.
add command on
capscaps download org/repo@tagadd alias in Calcit
thread-firstfor->thread-lastfor->>thread-asfor->%