-
Notifications
You must be signed in to change notification settings - Fork 9.2k
fixed openapi specification #20392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed openapi specification #20392
Conversation
@pk8189 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/26/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (03/26/25)1 label was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue states issue with docs/api-reference/v1/openapi.json
while the PR has changes to docs/api-reference/v2/openapi.json
Hi Tushar, should I create a new issue? As you can see in the description, there were 51 issues with the v2 OpenAPI specification, which is also mentioned in the issue. |
@pk8189 Thanks for the fixes. I'm curious - do you know the root cause? We currently auto-generate this doc so even with these fixes, more errors will pop up if we don't fix root cause. |
Hey , you can create a new issue - the point is the issue and the PR doesn't really match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pk8189 still working on it ?
Thanks for the PR , closing it due to staleness (let me know if you wish to continue) |
What does this PR do?
Fix the errors in the OpenAPI specification
OpenAPI linting before:
"errors": 52,
"infos": 4,
"warns": 1538
After:
"errors": 0,
"infos": 4,
"warns": 1538
Visual Demo (For contributors especially)
Functional Python and Typescript SDKs created using the fixed specification:
https://github.com/Sideko-Inc/calcom_py
https://github.com/Sideko-Inc/calcom_ts
Mandatory Tasks (DO NOT REMOVE)
[x ] I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I'm assuming this new spec needs to be fed into your documentation provider.
[ N/A] I confirm automated tests are in place that prove my fix is effective or that my feature works.