Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong dates on OOO due to summer time #20408

Merged
merged 5 commits into from
Mar 28, 2025

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Mar 27, 2025

What does this PR do?

This PR fixes wrong dates on OOO due to summer time.

  • Fixes CAL-4629

Why?

I'm currently in Paris on March 28 2025, and it's GMT+1 and CET (Central European Standard Time).
However, if I choose April 1 2025, that's after the summer time begins, which means GMT+2 and CEST (Central European Summer Time).

We've been using dayjs().utcOffset() which gives me the current offset (60), but we should get offset specifically for the chosen date (120).

Visual Demo (For contributors especially)

This error should no longer happen since this PR ↓

Screenshot.2025-03-28.at.12.01.23.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

linear bot commented Mar 27, 2025

Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 2:07pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 2:07pm

@eunjae-lee eunjae-lee marked this pull request as ready for review March 28, 2025 11:04
@graphite-app graphite-app bot requested a review from a team March 28, 2025 11:04
@dosubot dosubot bot added the 🐛 bug Something isn't working label Mar 28, 2025
Copy link

graphite-app bot commented Mar 28, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/28/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (03/28/25)

1 label was added to this PR based on Keith Williams's automation.

retrogtx
retrogtx previously approved these changes Mar 28, 2025
Copy link
Contributor

github-actions bot commented Mar 28, 2025

E2E results are ready!

@eunjae-lee eunjae-lee merged commit a7b1981 into main Mar 28, 2025
39 checks passed
@eunjae-lee eunjae-lee deleted the eunjae/cal-4629-ooo-shows-wrong-dates branch March 28, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants