Additional steps for glueing toghether

[Shelob9]

Proposed additions to #6

[hellofromtonya]

Change the conditional into a guard clause like this:

if (!$this->argsModify->shouldFilter($request)) {
	return $args;
}

return array_merge($args, $this->argsModify->getAdditionalQueryArguments());

Why is this better?

1. It'll run slightly faster for merging the changes with the incoming. How?:
   • PHP does not have to do a variable assignment and memory update (i.e. updating the value of that variable in memory) on line 97.
   • PHP does not have to look up the value of the variable on line 99 before returning it.
2. Architecturally you are:
   • communicating intent that this conditional is a stopping point (i.e. "no-go"), meaning no filtering work is going to happen .... so bail out.
   • you stop a no-go condition from flowing through your code.

[hellofromtonya]

Formatting inconsistency: Remove the extra space before the $this variable.

[hellofromtonya]

This method is a setter and not a getter. Update the DocBlock to describe what it does.

[hellofromtonya]

When we flip this around to make the shouldFilter a guard clause, then we get:

1. more readable code as the intent is clearly communicated, i.e. "stop her if we should not filter."
2. faster code as we don't have to do the variable assignment or look up when doing the processing work.
3. a better design as a "no go" is not allowed to continue flowing.

if (!$this->shouldFilter($args['post_type'])) {
    return $args;
}

$this->setRequest($request);
add_filter('posts_pre_query', [FilterWPQuery::class, 'posts_pre_query'], 10, 2);

$args['post_type'] = $this->restBasesToPostTypeSlugs($request[ModifySchema::ARGNAME]);
return array_merge($this->getAdditionalQueryArguments(), $args);

[hellofromtonya]

Change the conditional into a guard clause like this:

if ($this->schemaModify->shouldFilter($post_type)) {
	return $query_params;
}

return array_merge($query_params, $this->schemaModify->getAdditionalSchemaArguments());

Why is this better?

1. It'll run slightly faster for merging the changes with the incoming. How?:
   • PHP does not have to do a variable assignment and memory update (i.e. updating the value of that variable in memory) on line 81.
   • PHP does not have to look up the value of the variable on line 84 before returning it.
2. Architecturally you are:
   • communicating intent that this conditional is a stopping point (i.e. "no-go"), meaning no filtering work is going to happen .... so bail out.
   • you stop a no-go condition from flowing through your code.

[hellofromtonya]

1. I see a lot of redundant code here that code go into a Trait. Then use the trait in each of these anonymous classes.
2. I'd move the object creation to a separate method, i.e. one method for createSchemaModify and createQueryModify. In doing so, it makes the code more readable.