chore: update eslint #3356
chore: update eslint #3356
Conversation
|
The mobile version of example app from this branch is ready! You can see it here |
3 similar comments
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
.eslintrc
Outdated
| "react-native/no-raw-text": "off", | ||
| "react-native-a11y/has-accessibility-hint": "off", | ||
| // crashes for some reason with error: TypeError: Cannot read properties of undefined (reading 'type') | ||
| "react-native-a11y/has-valid-accessibility-state": "off" |
There was a problem hiding this comment.
accessibilityState={{ ...accessibilityState, disabled }} in FAB.tsx and AnimatedFAB.tsx causes this rule to crash. If I extract creation of this object to variable, e.g.
const newAccessibilityState= { ...accessibilityState, disabled };
and then use it in component this way:
accessibilityState={newAccessibilityState}
It does not crash anymore. @thymikee, @lukewalczak, do you think this is a bug with this rule and should be reported to react-native-a11y repo?
There was a problem hiding this comment.
File a bug in react-native-a11y
There was a problem hiding this comment.
|
The mobile version of example app from this branch is ready! You can see it here |
|
After updating to newest callstack eslint config, I'm getting error that plugins are not present: I was able to resolve it by recreating yarn.lock with new package versions. Unfortunately this causes around 18 errors in TS, that I haven't been able to resolve yet. :( Here's the TS error output: |
jaworek
force-pushed
the
eslint-update
branch
from
0697dbe
to
02accf8
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
Eslint config of RN Paper is quite outdated. As a part of testing latest @callstack/eslint-config, I updated it.
Summary
Update eslint config, eslint, and plugins that are used.
Test plan
Pipelines pass and there are no regressions in functionality.