forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix ruby unit tests (facebook#48498)
Summary: As a prerequisite of enabling running unit tests on CI again, this PR suggests changes needed to the Ruby unit tests. I've added comments on the code below, justifying changes where I deem a justification might be needed. For use internally, I suggest accessing the folly_config and boost_config directly via the `Helpers` class instead of the `get_folly_config` and `get_boost_config` because these global functions are defined in `react_native_pods` which would be result in circular requires. An alternative would be to move these global functions to a separate file. ## Changelog: [INTERNAL] [FIXED] - Fix Ruby unit tests. Pull Request resolved: facebook#48498 Test Plan: - `cd packages/react-native` - `./scripts/run_ruby_tests.sh` Reviewed By: rshest Differential Revision: D67852809 Pulled By: cipolleschi fbshipit-source-id: 54d8bd708a9e3fd9aef3569ac89ec6ddcd244437
- Loading branch information
1 parent
5ce0738
commit 7a85b91
Showing
4 changed files
with
21 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters