Remove startEmptySurface from SurfaceManager (facebook#48479)

Summary: Pull Request resolved: facebook#48479 [Changelog] [Internal] - Remove startEmptySurface from SurfaceManager Most of the logic deleted here does not seem to be needed as the core functionality is in: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.cpp#L88-L96 And this code path can be reached both via - `startSurface` (by passing in an empty `moduleModule` OR - `startEmptySurface` Reviewed By: shwanton, rubennorte Differential Revision: D67805569 fbshipit-source-id: e3d06dcaa637996498a6cb52b5c1b98f740326ce
callstack · Jan 6, 2025 · c4edfe7 · c4edfe7
1 parent 0154372
commit c4edfe7
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 23 deletions.
diff --git a/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.cpp b/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.cpp
@@ -22,10 +22,6 @@ SurfaceHandler::SurfaceHandler(
   parameters_.surfaceId = surfaceId;
 }
 
-SurfaceHandler::SurfaceHandler(SurfaceId surfaceId) noexcept {
-  parameters_.surfaceId = surfaceId;
-}
-
 SurfaceHandler::SurfaceHandler(SurfaceHandler&& other) noexcept {
   operator=(std::move(other));
 }

diff --git a/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.h b/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.h
@@ -63,13 +63,6 @@ class SurfaceHandler {
    */
   SurfaceHandler(const std::string& moduleName, SurfaceId surfaceId) noexcept;
 
-  /*
-   * Can be constructed anytime with a `surfaceId`.
-   * As the module name is not passed, the surface will have to be rendered
-   * manually by the caller (AppRegistry will not be called).
-   */
-  SurfaceHandler(SurfaceId surfaceId) noexcept;
-
   virtual ~SurfaceHandler() noexcept;
 
   /*

diff --git a/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceManager.cpp b/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceManager.cpp
@@ -44,13 +44,6 @@ void SurfaceManager::startSurface(
   });
 }
 
-void SurfaceManager::startEmptySurface(
-    SurfaceId surfaceId,
-    const LayoutConstraints& layoutConstraints,
-    const LayoutContext& layoutContext) const noexcept {
-  startSurface(surfaceId, "", {}, layoutConstraints, layoutContext);
-}
-
 void SurfaceManager::stopSurface(SurfaceId surfaceId) const noexcept {
   visit(surfaceId, [&](const SurfaceHandler& surfaceHandler) {
     surfaceHandler.stop();

diff --git a/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceManager.h b/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceManager.h
@@ -38,11 +38,6 @@ class SurfaceManager final {
       const LayoutConstraints& layoutConstraints = {},
       const LayoutContext& layoutContext = {}) const noexcept;
 
-  void startEmptySurface(
-      SurfaceId surfaceId,
-      const LayoutConstraints& layoutConstraints = {},
-      const LayoutContext& layoutContext = {}) const noexcept;
-
   void stopSurface(SurfaceId surfaceId) const noexcept;
 
   void stopAllSurfaces() const noexcept;