Conversation
…and Chem commands
…rom documentation
10 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated LAMMPS writer (library + CLI surface area) and updates documentation/examples to focus on structure processing and BGF export.
Changes:
- Removed
src/io/lammpsand all public API/CLI options related to LAMMPS output (config types, format variants, CLI flags). - Updated
dforgecommands to drop LAMMPS write paths and adjust stdout default formats (bio→BGF, chem→MOL2). - Cleaned up docs and examples by removing LAMMPS references and sample drug datasets/assets.
Reviewed changes
Copilot reviewed 19 out of 37 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Updates crate-level docs to remove LAMMPS export claims. |
| src/io/mod.rs | Removes LAMMPS module wiring, exports, and Format variants. |
| src/io/lammps/writer.rs | Deletes the LAMMPS writer implementation (data/settings/package generation). |
| src/io/lammps/mod.rs | Deletes the LAMMPS submodule entry point. |
| src/bin/dforge/util/convert.rs | Removes CLI→library conversions for removed LAMMPS formats/boundary types. |
| src/bin/dforge/io/infer.rs | Removes .data/.lammps/.settings output inference for LAMMPS formats. |
| src/bin/dforge/display/error.rs | Updates user hints to remove LAMMPS from supported output formats and parsing hint branches. |
| src/bin/dforge/config/mod.rs | Removes the LAMMPS config builder module export. |
| src/bin/dforge/config/lammps.rs | Deletes the LAMMPS config builder. |
| src/bin/dforge/commands/chem.rs | Removes LAMMPS writing/config handling; defaults stdout output to MOL2. |
| src/bin/dforge/commands/bio.rs | Removes LAMMPS writing/config handling; defaults stdout output to BGF. |
| src/bin/dforge/cli.rs | Removes LAMMPS CLI flags/options and output format variants. |
| examples/drugs/images/penicillin-g-structure.svg | Removes legacy drug example image asset. |
| examples/drugs/images/morphine-structure.svg | Removes legacy drug example image asset. |
| examples/drugs/images/methamphetamine-structure.svg | Removes legacy drug example image asset. |
| examples/drugs/images/metformin-structure.svg | Removes legacy drug example image asset. |
| examples/drugs/images/mdma-structure.svg | Removes legacy drug example image asset. |
| examples/drugs/images/ketamine-structure.svg | Removes legacy drug example image asset. |
| examples/drugs/images/ibuprofen-structure.svg | Removes legacy drug example image asset. |
| examples/drugs/images/cocaine-structure.svg | Removes legacy drug example image asset. |
| examples/drugs/images/aspirin-structure.svg | Removes legacy drug example image asset. |
| examples/drugs/images/acetaminophen-structure.svg | Removes legacy drug example image asset. |
| examples/drugs/README.md | Removes LAMMPS-focused drug example documentation. |
| examples/drugs/Penicillin-G.sdf | Removes legacy drug example input. |
| examples/drugs/Morphine.sdf | Removes legacy drug example input. |
| examples/drugs/Methamphetamine.sdf | Removes legacy drug example input. |
| examples/drugs/Metformin.sdf | Removes legacy drug example input. |
| examples/drugs/MDMA.sdf | Removes legacy drug example input. |
| examples/drugs/Ketamine.sdf | Removes legacy drug example input. |
| examples/drugs/Ibuprofen.sdf | Removes legacy drug example input. |
| examples/drugs/Cocaine.sdf | Removes legacy drug example input. |
| examples/drugs/Aspirin.sdf | Removes legacy drug example input. |
| examples/drugs/Acetaminophen.sdf | Removes legacy drug example input. |
| examples/basic/README.md | Updates basic examples to remove LAMMPS outputs from commands/outputs. |
| README.md | Updates README narrative and code example to use BGF export instead of LAMMPS. |
| MANUAL.md | Updates CLI manual to remove LAMMPS formats/options and adjust output rules. |
| ARCHITECTURE.md | Updates architecture docs/diagrams to remove the LAMMPS writer component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removed the LAMMPS writer implementation (
src/io/lammps/) and associated configuration types from the library and CLI. This change streamlines the project's focus on structure parameterization and BGF export, reducing maintenance overhead for legacy formats. TheLammpsDataandLammpsSettingsoutput formats have been removed from the public API and CLI options.Changes:
Removed LAMMPS Writer:
src/io/lammps/module andLammpsConfigstruct.write_lammps_package,write_lammps_data, andwrite_settings_filefunctions.src/io/mod.rsto remove re-exports and module references.Updated CLI:
LammpsOptionsstruct and associated flags (--lmp-*) fromcli.rs.LammpsDataandLammpsSettingsvariants fromBioOutputFormatandChemOutputFormat.commands/bio.rsandcommands/chem.rsto remove LAMMPS writing logic.config/lammps.rsbuilder.Cleaned Up Dependencies & Docs:
MANUAL.mdto remove LAMMPS command references and options.README.mdexamples to use BGF export instead of LAMMPS.ARCHITECTURE.mddiagrams and descriptions to reflect the removal of the LAMMPS writer..data,.settings) from documentation examples.Refactored Examples:
Acetaminophen.sdf, etc.) that were primarily used for LAMMPS testing.examples/basic/README.mdto showcase BGF and MOL2/SDF workflows.