Skip to content

Comments

Replace hardcoded environment values in Makefile ports target with configurable variables#104

Closed
Copilot wants to merge 5 commits intofeature/ingressfrom
copilot/sub-pr-92-another-one
Closed

Replace hardcoded environment values in Makefile ports target with configurable variables#104
Copilot wants to merge 5 commits intofeature/ingressfrom
copilot/sub-pr-92-another-one

Conversation

Copy link
Contributor

Copilot AI commented Nov 26, 2025

The ports target had hardcoded environment-specific values (calypr-demo.ddns.net, 100.22.124.96) that would not work for other deployments.

Changes

  • New variables added to Makefile configuration section:

    • TLS_SECRET_NAME (default: argo-tls) - TLS secret name for certificates
    • EXTERNAL_IP (optional) - external IP for ingress, skipped if unset
  • Updated ports target to use:

    • ${ARGO_HOSTNAME} for Let's Encrypt certificate paths
    • ${TLS_SECRET_NAME} for all TLS secret references
    • ${EXTERNAL_IP} with conditional assignment

Usage

export ARGO_HOSTNAME=my-domain.com
export EXTERNAL_IP=192.168.1.100      # optional
export TLS_SECRET_NAME=my-tls-secret  # optional, defaults to argo-tls
make ports

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 4 commits November 26, 2025 18:04
…ariables

Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback from review on feature/ingress PR Replace hardcoded environment values in Makefile ports target with configurable variables Nov 26, 2025
Copilot AI requested a review from bwalsh November 26, 2025 18:11
@bwalsh bwalsh closed this Nov 26, 2025
@bwalsh bwalsh deleted the copilot/sub-pr-92-another-one branch November 26, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants