Replace hardcoded environment values in Makefile ports target with configurable variables#104
Closed
Copilot wants to merge 5 commits intofeature/ingressfrom
Closed
Replace hardcoded environment values in Makefile ports target with configurable variables#104Copilot wants to merge 5 commits intofeature/ingressfrom
Copilot wants to merge 5 commits intofeature/ingressfrom
Conversation
Merged
…ariables Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback from review on feature/ingress PR
Replace hardcoded environment values in Makefile ports target with configurable variables
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
portstarget had hardcoded environment-specific values (calypr-demo.ddns.net,100.22.124.96) that would not work for other deployments.Changes
New variables added to Makefile configuration section:
TLS_SECRET_NAME(default:argo-tls) - TLS secret name for certificatesEXTERNAL_IP(optional) - external IP for ingress, skipped if unsetUpdated
portstarget to use:${ARGO_HOSTNAME}for Let's Encrypt certificate paths${TLS_SECRET_NAME}for all TLS secret references${EXTERNAL_IP}with conditional assignmentUsage
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.