-
Notifications
You must be signed in to change notification settings - Fork 0
feature/improve repo registration #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
a305d8a
move gitapp-callback to argocd ns
bwalsh c137b01
improves gitapp-callback
bwalsh b7e294c
adds vault to callback
bwalsh 7b0d6a4
increase probe time
bwalsh 82ad908
fix mountpoint
bwalsh 4abf95c
adds secrets ux
bwalsh 704a082
adds secrets ux
bwalsh 0aa50cb
improve update form
bwalsh 8b749d7
improve sidebar
bwalsh c68fd1e
githubAppName
bwalsh 4661b08
create PR
bwalsh 63dde7a
adds git
bwalsh 6b3cbfb
fix secret config
bwalsh b4bb416
deprecate submodule
bwalsh f3bd4da
improve git clone
bwalsh b8bddfd
adds git cred init
bwalsh 482a860
adds git cred init
bwalsh 0235a25
adds to deploy volume
bwalsh 5c63be3
init git credentials
bwalsh 350d033
fix git config
bwalsh 4ab967e
adds diagrams
bwalsh 12e7de4
remove unnecessary check for current git dir
bwalsh 61fa5ea
adds yaml
bwalsh 40b1018
adds author name and email
bwalsh be62a63
improve reviewers
bwalsh cf26555
rm 'Argo Workflows'
bwalsh a4c86e2
check if branch exists
bwalsh e9e9306
improve existing branch update
bwalsh 36fc331
update doc
bwalsh cc9ac1d
select repository
bwalsh af49aa3
adds select repo
bwalsh 9909992
changes PK
bwalsh dc91157
improve not found error msg
bwalsh 2b4c6ca
adds repo full_name
bwalsh 604bb27
improve 1..N installation..repo
bwalsh 57e3ba6
improve UX
bwalsh a2a3119
improve readability
bwalsh da8c1e1
adds avatar
bwalsh a3adf81
use png
bwalsh e6c35bc
use png
bwalsh a788375
PR feedback
bwalsh 15f5a60
restore annotations
bwalsh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -49,6 +49,7 @@ check-vars: | |||||||||||||
| @test -f "$(GITHUBHAPP_PRIVATE_KEY_FILE_PATH)" || (echo "Error: GITHUBHAPP_PRIVATE_KEY_FILE_PATH file '$(GITHUBHAPP_PRIVATE_KEY_FILE_PATH)' not found. Create the file before installing" && exit 1) | ||||||||||||||
| @test -n "$(GITHUBHAPP_PRIVATE_KEY_VAULT_PATH)" || (echo "Error: GITHUBHAPP_PRIVATE_KEY_VAULT_PATH is undefined. Run 'export GITHUBHAPP_PRIVATE_KEY_VAULT_PATH=...' before installing" && exit 1) | ||||||||||||||
| @test -n "$(GITHUBHAPP_INSTALLATION_ID)" || (echo "Error: GITHUBHAPP_INSTALLATION_ID is undefined. Run 'export GITHUBHAPP_INSTALLATION_ID=...' before installing" && exit 1) | ||||||||||||||
| @test -n "$(GITHUBHAPP_CALLBACK_FLASK_KEY)" || (echo "Error: GITHUBHAPP_CALLBACK_FLASK_KEY is undefined. Run 'export GITHUBHAPP_CALLBACK_FLASK_KEY=...' before installing" && exit 1) | ||||||||||||||
| @echo "✅ All GITHUBHAPP environment variables are set." | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
|
|
@@ -205,6 +206,9 @@ argo-stack: | |||||||||||||
| --set githubStatusProxy.privateKeySecret.name="${GITHUBHAPP_PRIVATE_KEY_SECRET_NAME}" \ | ||||||||||||||
| --set githubStatusProxy.privateKeySecret.key=privateKey \ | ||||||||||||||
| --set githubStatusProxy.logLevel="DEBUG" \ | ||||||||||||||
| --set-string gitappCallback.githubRepoUrl="${GITHUBHAPP_CALLBACK_REPO_URL}" \ | ||||||||||||||
| --set-string gitappCallback.githubUserName="${GITHUBHAPP_CALLBACK_USER_NAME}" \ | ||||||||||||||
| --set-string gitappCallback.secretKey="${GITHUBHAPP_CALLBACK_FLASK_KEY}"\ | ||||||||||||||
| -f helm/argo-stack/admin-values.yaml \ | ||||||||||||||
| -f - | ||||||||||||||
|
|
||||||||||||||
|
|
@@ -225,6 +229,10 @@ ports: | |||||||||||||
| kubectl create secret tls ${TLS_SECRET_NAME} -n calypr-api --cert=/tmp/fullchain.pem --key=/tmp/privkey.pem || true | ||||||||||||||
| kubectl create secret tls ${TLS_SECRET_NAME} -n calypr-tenants --cert=/tmp/fullchain.pem --key=/tmp/privkey.pem || true | ||||||||||||||
| sudo rm /tmp/fullchain.pem /tmp/privkey.pem | ||||||||||||||
| # | ||||||||||||||
|
||||||||||||||
| # | |
| # | |
| @if [ -z "$(VAULT_TOKEN)" ]; then \ | |
| echo "Error: VAULT_TOKEN environment variable must be set before creating gitapp-vault-token secret" >&2; \ | |
| exit 1; \ | |
| fi; \ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space before backslash continuation. Line 211 has a backslash immediately after the closing quote without a space, while other continuation lines in the Makefile follow the pattern of having a space before the backslash. This inconsistency can cause readability issues.