Skip to content

v prefix #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwalsh merged 1 commit into from
Feb 11, 2026
Merged

v prefix #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bump-tag.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ fi

BRANCH="$(git rev-parse --abbrev-ref HEAD)"


echo "Latest branch: $BRANCH"
echo "Latest tag: $LATEST_TAG"
echo "New tag: $NEW_TAG (files will use ${NEW_FILE_VER})"
Comment on lines 116 to 118
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script logs New tag: $NEW_TAG before the v prefix is applied later, so the printed “New tag” won’t match the tag that actually gets created (e.g., logs 1.2.3 but creates v1.2.3). Consider either applying the prefix before the logging, or logging a separate NEW_GIT_TAG/TAG_NAME variable that matches what will be pushed.

Copilot uses AI. Check for mistakes.
Expand All @@ -138,11 +139,14 @@ fi

# Run tests/builds (non-fatal for Python tests)


# Commit, tag and push
NEW_TAG="v${NEW_TAG}"
git commit -m "chore(release): bump to ${NEW_TAG}" || echo "No changes to commit"
Comment on lines 143 to 145
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEW_TAG is initially a plain semver used for file versions, then it is mutated to include the v prefix for Git tagging. Reusing the same variable for two different meanings makes the flow harder to follow and can lead to subtle mistakes if more steps are added between version updates and tagging. Use distinct variables (e.g., NEW_VERSION for files and NEW_TAG/NEW_GIT_TAG for the Git tag) to keep responsibilities clear.

Copilot uses AI. Check for mistakes.
git tag -a "${NEW_TAG}" -m "Release ${NEW_TAG}"
echo "Created tag. Please push tag ${NEW_TAG} on branch ${BRANCH}."

echo "Created tag. Please push tag ${NEW_TAG} on branch ${BRANCH}."
echo "To push, run:"
echo git push origin "${BRANCH}"
echo git push origin "${NEW_TAG}"

Loading