Skip to content

fix bug #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewpeterkort merged 2 commits into from
Feb 11, 2026
Merged

fix bug #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
795907b
fix bug
matthewpeterkort Feb 11, 2026
aedb051
fix test
matthewpeterkort Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/precommit/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ func stagedLFSOID(ctx context.Context, path string) (string, bool, error) {
hex := strings.TrimPrefix(line, "oid sha256:")
hex = strings.TrimSpace(hex)
if hex != "" {
oid = "sha256:" + hex
oid = hex
}
// keep scanning a bit in case spec is below (rare), but we can break once both are found.
}
Expand Down
10 changes: 5 additions & 5 deletions cmd/precommit/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,11 @@ func TestHandleUpsertWritesLFSPointerCache(t *testing.T) {
if pathCache.Path != "data/file.bin" {
t.Fatalf("expected path entry to be data/file.bin, got %q", pathCache.Path)
}
if pathCache.LFSOID != "sha256:deadbeef" {
t.Fatalf("expected lfs oid sha256:deadbeef, got %q", pathCache.LFSOID)
if pathCache.LFSOID != "deadbeef" {
t.Fatalf("expected lfs oid deadbeef, got %q", pathCache.LFSOID)
}

oidEntry := oidEntryFile(oidsDir, "sha256:deadbeef")
oidEntry := oidEntryFile(oidsDir, "deadbeef")
oidData, err := os.ReadFile(oidEntry)
if err != nil {
t.Fatalf("read oid entry: %v", err)
Expand All @@ -106,8 +106,8 @@ func TestHandleUpsertWritesLFSPointerCache(t *testing.T) {
if err := json.Unmarshal(oidData, &oidCache); err != nil {
t.Fatalf("unmarshal oid entry: %v", err)
}
if oidCache.LFSOID != "sha256:deadbeef" {
t.Fatalf("expected oid entry sha256:deadbeef, got %q", oidCache.LFSOID)
if oidCache.LFSOID != "deadbeef" {
t.Fatalf("expected oid entry deadbeef, got %q", oidCache.LFSOID)
}
if len(oidCache.Paths) != 1 || oidCache.Paths[0] != "data/file.bin" {
t.Fatalf("expected oid paths to include data/file.bin, got %v", oidCache.Paths)
Expand Down