Give errors to Oban as 2 tuples #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cambiatus/backend/cambiatus#304
lucca65
approved these changes
Jul 11, 2023
lucca65
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note
This is a subset of #306
What issue does this PR close
Closes #304
Changes Proposed ( a list of new changes introduced by this PR)
Return 2 tuple errors to Oban. 4 tuple errors are generated when
Multi.newis upstream ofRepo.transaction.How to test ( a list of instructions on how to test this PR)
Existing unit test coverage. They passed for me locally, after running
mix formatandmix credo.Please note
I am submitting two versions of this change. This PR addresses the error handling. The next PR will have that, and it will include the credo check.