Newest version of mpi4py is incompatible#18
Merged
e-moral-sanchez merged 2 commits intodevelfrom Aug 30, 2024
Merged
Conversation
campospinto
approved these changes
Aug 30, 2024
Owner
campospinto
left a comment
campospinto
left a comment
There was a problem hiding this comment.
The version restriction seems indeed justified. Thanks!
Collaborator
Author
|
@campospinto Sorry I didn't see before, but the restriction of mpi4py < 4 was already done by Yaman in the main Psydac respository pyccel@6850cb0 . |
Owner
Well, that will be a PR easy to merge in the main Psydac repo then ;) |
e-moral-sanchez
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it can be seen in PR #19 , the tests do not run with the latest version of mpi4py . This PR just ensures that during the installation a previous version is installed instead.
This function is used in https://github.com/campospinto/psydac_dev/blame/2ed9431fd8a3bbcf46584756a4d7ffd290c2d36b/psydac/ddm/cart.py#L268C13-L268C141 . Now it only accepts two arguments: https://docs.open-mpi.org/en/v5.0.x/man-openmpi/man3/MPI_Group_translate_ranks.3.html