Move jquery import out of component #9603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
approved these changes
Feb 5, 2025
To avoid double import of jquery, it's now the responsability of the app to load wanted jquery and jquery dependencies.
ger-benjamin
force-pushed
the
GSGMF-2118-fix-double-jquery
branch
from
fabf472 to
3a8475a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid double import of jquery, it's now the responsability of the app to load wanted jquery and jquery dependencies.
datepicker are still not working. I use here a more aggressive method, but I think that makes sens. That allows the user to have more choice on what he want to import.
See JIRA issue: GSGMF-2118.
Examples
Storybook
API help
API documentation