[WFS] Add startIndex Support in URL generation and supportsStartIndex Method #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronitjadhav
changed the title
jahow
reviewed
May 11, 2024
src/wfs/url.ts
Outdated
| @@ -51,6 +53,15 @@ export function generateGetFeatureUrl( | |||
| const extentJoined = extent.join(','); | |||
| newParams.BBOX = extentCrs ? `${extentJoined},${extentCrs}` : extentJoined; | |||
| } | |||
| if (startIndex !== undefined) { | |||
| if (version >= '2.0.0') { | |||
There was a problem hiding this comment.
I think you can remove this check altogether; many implementations (inc. GeoServer) will support startIndex even using lower versions of WFS, so adding it anyway cannot hurt. On the other side, since we now provide a supportsStartIndex method in the endpoint, it is up to the application code to handle the case where this might have no effect at all (e.g. disabling a field).
There was a problem hiding this comment.
Yes, sounds correct.
I have made the suggested updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following updates:
startIndexin thegetFeatureUrlandgenerateGetFeatureUrlfunctionssupportsStartIndexmethod in theWfsEndpointclass.