Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dispatch-value-spec/defmethod-arities to multimethods without them #157

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

camsaul
Copy link
Owner

@camsaul camsaul commented Oct 3, 2023

Resolves #99

@camsaul camsaul enabled auto-merge (squash) October 3, 2023 21:31
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/toucan2/types.clj 100.00% <100.00%> (ø)
src/toucan2/jdbc/result_set.clj 85.18% <0.00%> (+1.03%) ⬆️
src/toucan2/pipeline.clj 77.01% <0.00%> (ø)
src/toucan2/save.clj 70.27% <33.33%> (-3.26%) ⬇️
src/toucan2/tools/after.clj 76.47% <0.00%> (+0.35%) ⬆️
src/toucan2/tools/after_select.clj 86.95% <33.33%> (-3.96%) ⬇️
src/toucan2/query.clj 85.83% <0.00%> (ø)
src/toucan2/jdbc/read.clj 75.00% <20.00%> (-2.95%) ⬇️
src/toucan2/model.clj 81.17% <0.00%> (-2.97%) ⬇️

📢 Thoughts on this report? Let us know!.

@camsaul camsaul disabled auto-merge October 3, 2023 21:32
@camsaul camsaul merged commit 0cb6996 into master Oct 3, 2023
9 of 10 checks passed
@camsaul camsaul deleted the add-dispatch-value-spec-and-defmethod-arities branch October 3, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dispatch-value-spec and defmethod-arities to all multimethods that don't have them
1 participant