Add native implementation for IKVReduce in toucan2.instance.Instance #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, if kv-reduce is called on an Instance, the code follows the slow unoptimal path of calling 'reduce' on the map and constructing MapEntries.
alexander-yakushev
force-pushed
the
instance-reducekv
branch
from
758a334
to
9825286
Compare
|
amazing! Thank you |
|
Live in 1.0.544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, if kv-reduce is called on an Instance, the code follows the slow unoptimal path of calling 'reduce' on the map and constructing MapEntries.
This happens notably in Metabase in
instance->metadata(https://github.com/metabase/metabase/blob/a43b09cdfed17151e4cd2dd34feeecb3f0e012f4/src/metabase/lib/metadata/jvm.clj#L47) but I've seen it in other places too.