Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[instance] Provide non-vararg arity for update-original-and-current #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexander-yakushev
Copy link
Contributor

The function toucan2.instance/update-original-and-current appears to be frequently invoked inside toucan2.tools.transformed/apply-result-row-transform. The call chain involves passing args with apply in multiple functions, which generates redundant garbage (redundant because apply-result-row-transform doesn't pass any args, just f).

The PR adds an explicit f-only arity to functions in the call chain.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.20%. Comparing base (e14a45e) to head (952cf41).

Files with missing lines Patch % Lines
src/toucan2/instance.clj 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   83.23%   83.20%   -0.04%     
==========================================
  Files          37       37              
  Lines        2511     2524      +13     
  Branches      215      214       -1     
==========================================
+ Hits         2090     2100      +10     
- Misses        206      210       +4     
+ Partials      215      214       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant