Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bpmn-js-color-picker colors in the "Set colors" menu #4826

Open
jarekdanielak opened this issue Feb 12, 2025 · 5 comments
Open

Use bpmn-js-color-picker colors in the "Set colors" menu #4826

jarekdanielak opened this issue Feb 12, 2025 · 5 comments
Labels
backlog Queued in backlog enhancement New feature or request good first issue Good for newcomers spring cleaning Could be cleaned up one day

Comments

@jarekdanielak
Copy link
Contributor

jarekdanielak commented Feb 12, 2025

Problem you would like to solve

When the color schema of the bpmn-js-color-picker changes, we need to manually adjust them in the Desktop Modeler menu action.

Proposed solution

Use the colors provided by bpmn-js-color-picker to build the menu.

Additional context

Follow up to #4820

@jarekdanielak jarekdanielak added the enhancement New feature or request label Feb 12, 2025
@jarekdanielak jarekdanielak changed the title Use bpmn-js-color-pickers colors in the "Set colors" menu Use bpmn-js-color-picker colors in the "Set colors" menu Feb 12, 2025
@jarekdanielak jarekdanielak added good first issue Good for newcomers spring cleaning Could be cleaned up one day backlog Queued in backlog labels Feb 12, 2025
@ypoleto
Copy link

ypoleto commented Feb 12, 2025

Hey, i'd like to work on this. Can I?

@jarekdanielak
Copy link
Contributor Author

@ypoleto sure! We don't assign tasks to external contributors, so you can just go ahead and submit your proposal.

Note that there was another person showing interest in this topic: #4820 (comment)

@ypoleto
Copy link

ypoleto commented Feb 12, 2025

Thank you! Can you be more clear about what the issue is about?

@jarekdanielak
Copy link
Contributor Author

Figuring this out is part of the fun 😉

Short story:

  • We have a bpmn-js-color-picker which adds a color picker to the context pad.
  • In Camunda Modeler we have an option to set element color with action menu (Edit > Set color).
  • Currently those colors are defined separately in the color picker and in the modeler. We'd like modeler to use the colors schema from the picker.

The rest I leave to you. Good luck!

@ypoleto
Copy link

ypoleto commented Feb 12, 2025

Oh, got it now! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog enhancement New feature or request good first issue Good for newcomers spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

2 participants