Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Wrong color used when applying from menu action #4756 #4820

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

ssidharth010
Copy link
Contributor

@ssidharth010 ssidharth010 commented Feb 6, 2025

Link to issue - #4756
Updated the color map

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2025

CLA assistant check
All committers have signed the CLA.

@jarekdanielak
Copy link
Contributor

Great little change, thank you!

I wonder if we can avoid this problem in the future by having a single source of truth for the colors both in the Desktop Modeler and in the bpmn-js-color-picker?

@jarekdanielak jarekdanielak added the bug Something isn't working label Feb 11, 2025
@nikku
Copy link
Member

nikku commented Feb 11, 2025

@jarekdanielak Color picker allows customization.

We could make it possible to retrieve the colors used by the picker (and build the menu from there). That would be my preferred approach. Any other idea you have in mind?

@jarekdanielak
Copy link
Contributor

We could make it possible to retrieve the colors used by the picker (and build the menu from there). That would be my preferred approach. Any other idea you have in mind?

This is exactly what I had in mind.

@ssidharth010 would you like to take your contribution further and draft such a solution or should we take it from here? 😉

@ssidharth010
Copy link
Contributor Author

@jarekdanielak for sure I can take a look and make the necessary changes.

@jarekdanielak
Copy link
Contributor

Let's merge this anyway to solve the problem.

@ssidharth010 if you want to continue, here's a follow up issue: #4826

@jarekdanielak jarekdanielak merged commit f33f28d into camunda:develop Feb 12, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants