Skip to content

Use gh to comment on PR #4980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Use gh to comment on PR #4980

merged 1 commit into from
Apr 11, 2025

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Apr 11, 2025

Proposed Changes

This removes the peter-evans action from the workflow which should save us some time updating the action. We don't use the update section of the action anyway.

Solution based on https://docs.github.com/en/actions/use-cases-and-examples/project-management/commenting-on-an-issue-when-a-label-is-added

I used fix in the initial comment to test the new workflow in action.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 11, 2025
@barmac barmac force-pushed the remove-peter-evans-action branch from d89bd3c to 5116f49 Compare April 11, 2025 07:28
@barmac barmac closed this Apr 11, 2025
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 11, 2025
@barmac barmac reopened this Apr 11, 2025
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 11, 2025
@barmac barmac changed the title Use gh to comment on PR Use gh to comment on PR Apr 11, 2025
Copy link

This Pull Request targets develop branch, but contains fix commits.

Consider targeting main instead.

@barmac
Copy link
Collaborator Author

barmac commented Apr 11, 2025

OK it works!

@barmac barmac force-pushed the remove-peter-evans-action branch from 8254c9c to 5116f49 Compare April 11, 2025 07:32
@barmac
Copy link
Collaborator Author

barmac commented Apr 11, 2025

It failed initially because I used issues permission instead of pull_requests.

@barmac barmac force-pushed the remove-peter-evans-action branch from 5116f49 to 35c28e6 Compare April 11, 2025 07:32
@barmac barmac requested review from a team, Buckwich and philippfromme and removed request for a team April 11, 2025 07:37
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one, and shows how we can simplify our lives 🌟

@nikku nikku changed the base branch from develop to main April 11, 2025 08:06
@nikku nikku changed the base branch from main to develop April 11, 2025 08:06
@barmac barmac merged commit f78d3b2 into develop Apr 11, 2025
11 checks passed
@barmac barmac deleted the remove-peter-evans-action branch April 11, 2025 08:17
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 11, 2025
@github-actions github-actions bot added this to the M88 milestone Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants