Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker image for the workers #447

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Conversation

ChrisKujawa
Copy link
Member

@ChrisKujawa ChrisKujawa commented Dec 6, 2023

Allow to specify a dockerImageTag as global parameter, to be used by the deployed worker (and maybe later starter, etc.)

This is to make sure that we use the same client version as the deployed/target zeebe cluster.

closes #446

Read the zeebeImage from the job payload, and extract the tag in order to reuse this
for the worker deployment
@ChrisKujawa ChrisKujawa requested a review from npepinpe December 6, 2023 13:30
Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@npepinpe
Copy link
Member

npepinpe commented Dec 6, 2023

ups, no bors here I guess 😄

I'll merge once tests pass

@ChrisKujawa
Copy link
Member Author

I can fix the test later.

@ChrisKujawa ChrisKujawa merged commit 1549c1c into main Dec 6, 2023
2 checks passed
@ChrisKujawa ChrisKujawa deleted the np-ck-worker-docker-image branch December 6, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure we run experiments with worker images using the same version as the target cluster
2 participants