RPM: Avoid needless runtime requirement on python3-setuptools #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setuptools is not used on runtime at all. pkg_resources (part of the python3-setuptools package) is used in 2 places: - console_scripts entry points (/usr/bin/*) on Python < 3.8 - subscription_manager.utils:get_client_versions - conditional on subscription_manager.version.pkg_version presence - hence never imported from the RPM package Hence, this is really only needed on RHEL 8 or lower, but the specfile conditionals do not seem to support RHEL 7 at all. No idea about SUSE but if they have at least Python 3.8 they should be good as well. This is from https://src.fedoraproject.org/rpms/subscription-manager/pull-request/36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools is not used on runtime at all.
pkg_resources (part of the python3-setuptools package) is used in 2 places:
Hence, this is really only needed on RHEL 8 or lower, but the specfile conditionals do not seem to support RHEL 7 at all.
No idea about SUSE but if they have at least Python 3.8 they should be good as well.
This is from https://src.fedoraproject.org/rpms/subscription-manager/pull-request/36