Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Add missing GLib dependency when building without DNF #3368

Conversation

debarshiray
Copy link
Contributor

GLib is required to build rhsmcertd(8). When building with DNF support, glib2-devel is pulled in by libdnf-devel. However, turning off DNF support doesn't disable building rhsmcertd(8). Therefore, the depedency needs to be listed explicitly.

GLib is required to build rhsmcertd(8).  When building with DNF support,
glib2-devel is pulled in by libdnf-devel.  However, turning off DNF
support doesn't disable building rhsmcertd(8).  Therefore, the depedency
needs to be listed explicitly.
Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit is better than implicit, thanks!

@ptoscano ptoscano merged commit ebe024d into candlepin:main Jan 11, 2024
16 of 17 checks passed
@debarshiray
Copy link
Contributor Author

Thanks @ptoscano !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants