Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added more AWS cloud facts #3387

Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat: Added more AWS cloud facts #3387

merged 1 commit into from
Apr 17, 2024

Conversation

jirihnidek
Copy link
Contributor

  • Card Id: CCT-366
  • Added two options "aws_region" and "aws_instance_type" to cloud facts to be able to provide better business intelligence
  • Extended unit tests

@jirihnidek
feat: Added more AWS cloud facts
df5776a 
* Card Id: CCT-366
* Added two options "aws_region" and "aws_instance_type" to cloud
  facts to be able to provide better business intelligence
* Extended unit tests
@cnsnyder cnsnyder requested review from a team and cnsnyder and removed request for a team April 8, 2024 14:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
rhsmlib/facts
   cloud_facts.py88890%100, 105, 109, 167, 173, 178, 183, 185
TOTAL18395469774% 

Tests Skipped Failures Errors Time
2647 14 💤 0 ❌ 0 🔥 42.973s ⏱️

@ptoscano ptoscano merged commit cc59a3e into main Apr 17, 2024
18 checks passed
@ptoscano ptoscano deleted the jhnidek/aws_region_and_instance_type branch April 17, 2024 14:55
jirihnidek added a commit that referenced this pull request Apr 23, 2024
@jirihnidek
feat: 1.28 Added more AWS cloud facts
754846c 
* Backport to 1.28 branch
* Original PR: #3387
  * Original commit: df5776a
* Card Id: CCT-366
* Added two options "aws_region" and "aws_instance_type" to cloud
  facts to be able to provide better business intelligence
* Extended unit tests
@jirihnidek jirihnidek mentioned this pull request Apr 23, 2024
Merged
m-horky pushed a commit that referenced this pull request May 14, 2024
@jirihnidek @m-horky
feat: 1.28 Added more AWS cloud facts
7cf5af5 
* Backport to 1.28 branch
* Original PR: #3387
  * Original commit: df5776a
* Card Id: CCT-366
* Added two options "aws_region" and "aws_instance_type" to cloud
  facts to be able to provide better business intelligence
* Extended unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptoscano ptoscano ptoscano approved these changes

@cnsnyder cnsnyder Awaiting requested review from cnsnyder cnsnyder was automatically assigned from candlepin/client-tools

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirihnidek @ptoscano