Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1.28 Added zone GCP fact #3391

Merged

Conversation

jirihnidek
Copy link
Contributor

  • Original PR: feat: Added zone GCP fact #3388
  • Card ID: CCT-385
  • Added fact about zone, where the instance is located
  • Extended unit test covering this new fact
  • Note: GCP does not provide any information about instance type

* Original PR: 3388
  * Original commit: 2d04f77
* Card ID: CCT-385
* Added fact about zone, where the instance is located
* Extended unit test covering this new fact
* Note: GCP does not provide any information about instance type
Copy link

Coverage

Coverage (computed on CentOS Stream 9) •
FileStmtsMissCoverMissing
rhsmlib/facts
   cloud_facts.py86989%94, 99, 103, 155, 161, 166, 171, 176, 178
TOTAL22296926258% 

Tests Skipped Failures Errors Time
2368 11 💤 0 ❌ 0 🔥 44.513s ⏱️

Copy link
Contributor

@m-horky m-horky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-horky m-horky merged commit c0e4989 into subscription-manager-1.28 May 14, 2024
10 of 11 checks passed
@m-horky m-horky deleted the jhnidek/1.28_cct-385_more_gcp_facts branch May 14, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants