-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove autoheal functionality from rhsmcertd #3455
Conversation
@jirihnidek Here is my I have three questions:
|
88ec8bc
to
6bb85f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It generally seems good, there are few things to fix. Also drop an extra import, see the flake8 failure (it appears also as inline notes in the "files changed" view in github).
It looks to me like auto_attach_initial_delay , auto_attach_offset, and NEXT_AUTO_ATTACH_UPDATE_FILE can also be removed from src/daemons/rhsmcertd.c. Do you know if that is correct?
Yes, it looks so.
What should I do about the deprication message from man/rhsmcertd.8 ?
Edit it to mention only one parameter, according to the changes done here.
That feature looks something to remove as well, and I'd do that in a separate commit/PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have same comments as Pino has.
a8aedb6
to
c56592f
Compare
Thank you @ptoscano and @jirihnidek for all of the help and patience. I believe I have addressed all of the issues you've identified so far. I will now squash all of the commits I created while resolving yourreview feedback. |
c56592f
to
f876115
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates, this seems better now; I'll give it a try later on
Thank you for the feedback @ptoscano |
84272c3
to
56005c8
Compare
Card ID: CCT-723 Removed autoheal sub-command from rhsmcertd because autoheal is useless in pure SCA mode..
56005c8
to
6504b8a
Compare
Card ID: CCT-723
Removed autoheal sub-command from rhsmcertd because autoheal is useless in pure SCA mode..