Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove artifacts of autoheal #3479

Closed
wants to merge 1 commit into from

Conversation

Glutexo
Copy link
Contributor

@Glutexo Glutexo commented Nov 29, 2024

Removed what remained after removing the autoheal option from Action clients.

Parts of option was removed in #3451 and #3225 for CCT-717 and ENT-5549.

Card IDs:

  • CCT-603

Removed what remained after removing the `autoheal` option from Action clients (ENT-5549).

Card IDs:
* CCT-603

Signed-off-by: Štěpán Tomsa <stomsa@redhat.com>
@Glutexo
Copy link
Contributor Author

Glutexo commented Nov 29, 2024

@ptoscano May I ask you for a review?

test/rhsmlib/dbus/test_register.py Show resolved Hide resolved
test/rhsmlib/services/test_products.py Show resolved Hide resolved
test/rhsmlib/services/test_register.py Show resolved Hide resolved
@Glutexo Glutexo closed this Dec 3, 2024
@Glutexo Glutexo deleted the remove-autoheal branch December 3, 2024 13:21
Copy link
Contributor Author

@Glutexo Glutexo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, Pino! 🙇🏻‍♂️ I addressed your comments.

After a discussion with Barbora and Matyáš, we agreed to rather put the command removals into a single pull request (#3476) as individual commits. The updated patch is thus in a commit 8b1dca9. Closing this pull request.

@@ -38,7 +38,6 @@
"releaseVer": {"id": 1, "releaseVer": "123123"},
"serviceLevel": "Pro Turbo HD Plus Ultra",
"owner": {"key": "admin"},
"autoheal": 1,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptoscano This looks like a sample answer from Candlepin too. Reverted then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, a similar CONSUMER_DATA object in test_identitycertlib.py doesn’t include the autodial key.

test/rhsmlib/dbus/test_register.py Show resolved Hide resolved
test/rhsmlib/services/test_products.py Show resolved Hide resolved
test/rhsmlib/services/test_products.py Show resolved Hide resolved
test/rhsmlib/services/test_register.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants