chore: Remove the --token authentication #3481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptoscano
suggested changes
Dec 10, 2024
There was a problem hiding this comment.
Thanks! It mostly LGTM, there is only one comment to fix which otherwise would look odd. Please rebase too.
Also note that there will be leftovers related to token & keycloak in both connection.py and cp_provider.cp; feel free to open a new PR to clean them up.
* Card ID: CCT-1038 The token-based authentication method was deprecated in RHEL 9.2 and RHEL 8.8. As this feature is no longer relevant, and due to its deprecation, it is safe to remove `--token` starting with RHEL 10.
pkoprda
force-pushed
the
remove-token
branch
from
8ee9c72 to
23070d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token-based authentication method was deprecated in RHEL 9.2 and RHEL 8.8. As this feature is no longer relevant, and due to its deprecation, it is safe to remove
--tokenstarting with RHEL 10.