Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Really run integration tests #3483

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: Really run integration tests #3483

merged 2 commits into from
Dec 10, 2024

Conversation

jirihnidek
Copy link
Contributor

@jirihnidek jirihnidek commented Dec 9, 2024 •
edited
Loading

  • Card ID: CCT-741
  • Initial support for tmt fix: Added initial support for tmt #3473 tested only installing of RPM, no test was triggered. This should be fixed now.
  • .fmf/version file was in wrong subdirectory (./systemtest)
  • test.sh did not have execute bit
  • Added missing Python packages to requirements.txt

@jirihnidek
fix: Fixed integration tests
a191a84 
* Card ID: CCT-741
* .fmf/version file was in wrong subdirectory (./systemtest)
* test.sh did not have execute bit
@cnsnyder cnsnyder requested review from a team and cnsnyder and removed request for a team December 9, 2024 16:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
TOTAL17674455274% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
2470 14 💤 0 ❌ 0 🔥 31.984s ⏱️

@jirihnidek jirihnidek changed the title fix: Fixed integration tests fix: Really run integration tests Dec 10, 2024
@jirihnidek jirihnidek marked this pull request as ready for review December 10, 2024 09:48
m-horky
m-horky approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@m-horky m-horky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

========== test session starts ==========
...
collecting ... collected 1 item
integration-tests/test_consumer.py::test_busctl_get_consumer_uuid PASSED [100%]
========== 1 passed in 0.37s ==========

LGTM

@m-horky m-horky merged commit 3763a93 into main Dec 10, 2024
24 checks passed
@m-horky m-horky deleted the jhnidek/fix_tmt branch December 10, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-horky m-horky m-horky approved these changes

@cnsnyder cnsnyder Awaiting requested review from cnsnyder cnsnyder was automatically assigned from candlepin/client-tools

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirihnidek @m-horky