You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to call D-Bus method RegisterWithActivationKeys() with
register option enable_content. When this option is not set,
then behavior is still the same. It means that content is
enabled by default, when system is registered with this D-Bus
method.
Added two unit tests
Some refactoring and bug fixes in separate commits
* When D-Bus method Register() was called with enable_content
option and the value was "false" or "0", then code evaluated
this value as True.
* Fixed this issue, because previous behavior was very confusing
* Refactored code a little bit.
* The method is static method
* It is possible to set default value, when enable_content
was not set at all.
* Allow to call D-Bus method RegisterWithActivationKeys() with
register option enable_content. When this option is not set,
then behavior is still the same. It means that content is
enabled by default, when system is registered with this D-Bus
method.
* Added two unit tests
In case the implementation is done- I tried using this subman build on rhel 10 with rhc copr builds that support this feature. I hit the same error as before when using activation key. Sharing the logs from rhsm.log- e found for domain: 'rhsm' 2025-01-09T08:12:27.625+01:00 [ERROR] rhsm-service:32088:MainThread @util.py:72 - Unknown arguments: dict_keys(['enable_content']) Traceback (most recent call last): File "/usr/lib64/python3.12/site-packages/rhsmlib/dbus/util.py", line 70, in dbus_handle_exceptions return func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib64/python3.12/site-packages/rhsmlib/dbus/objects/register.py", line 499, in RegisterWithActivationKeys dbus_sender.set_cmd_line(sender=self.sender, cmd_line=self.cmd_line) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib64/python3.12/site-packages/rhsmlib/dbus/objects/register.py", line 265, in register_with_activation_keys enable_content: bool = self._remove_enable_content_option(register_options, default=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib64/python3.12/site-packages/rhsmlib/services/register.py", line 67, in register # signature we want to consider that an error. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rhsmlib.services.exceptions.ValidationError: Unknown arguments: dict_keys(['enable_content'])
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jirihnidek
force-pushed
the
jhnidek/register_activation_keys_and_enable_content_opt
branch
from
RegisterWithActivationKeys()withregister option
enable_content. When this option is not set,then behavior is still the same. It means that content is
enabled by default, when system is registered with this D-Bus
method.