Switch pdfrw to pypdf #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without pdftk, dungeon-sheets was not able to merge the various files produced by the fillable pdf forms. This patch adds a function that uses pdfrw to merge to pdfs.
Switch the fallback function to fill pdf forms to pypdf.
Pypdf has a simpler interface for form filling and appears
to be somewhat more robust that pdfrw. Also, this yields
pdfs in version 1.7 instead of 1.3, and it eliminates a
dependency on pdfrw. Finally, the pdfrw code appeared to
be buggy:
fill_pdf_template.py, line 454, in _make_pdf_pdfrw
this_field = annot[FIELD][1:-1]
TypeError: 'NoneType' object is not subscriptable
Unfortunately, this patch is not able to flatten pdfs,
since this functionality isn't implemented in pypdf
(it isn't implemented in pdfrw either).
This is a bugfix (no issue reported).
When filling forms with pypdf, the old blank personality sheet gave the following error: Font dictionary for /Helvetica not found. This patch uses the blank personality sheet split out from the current WotC fillable character sheet, with an added pdf bookmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has three patches that improve pdf handling in the absence of pdftk. This lays some further groundwork for getting rid of pdftk in the future, and it gets rid of pdfrw now.
The first patch adds fallback merging separate pdfs with pypdf. The second patch moves fallback pdf filling code from pdfrw to pypdf. The last patch silences a (harmless) warning from the fillable personality sheet.
The pdfrw code for filling a pdf form contained a bug as well, which is fixed with this PR.