Feature pages: Sort spells by level and name #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, spells were one long list organised alphabatically. This patch makes it possible to either sort spells alphabetically or by level (and then alphabetically within each level). The patch implements this feature using command-line options. Either the user can specify --spell-order or -S to order by level and name. Default is alphabetical order. Furthermore, this patch removes two places in character.py in which spells were ordered, but the resulting order wasn't used anywhere anyway.
This patch adds a subsection for each spell level when the user has selected to order spells by level. The patch keeps count of the spell level and adds a new header with every increase of spell level in the list of spells (i.e., headers like: Cantrips; 1st Level Spells; 2nd Level Spells, and so on). Add a test as well to check that the right spell headers also show up for the spells sorted by level.
This patch documents the makesheets commandline option to order spells by level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These four patches help optionally sorting spells by both level and name, instead of by name only. I'll admit that the first patch is slightly off-topic.
The first patch adds a short overview of a character's spellcasting details to the spellcasting section of the feature pages, see example:
The second patch adds an commandline option to sort spells by level and name:
--spells-by-level, -S Order spells by level in the feature pagesand implements it.The third patch implements headers and pdf bookmarks for each spell level in the feature pages.
The fourth patch adds documentation.
These patches work for both the regular and the fancy latex pages.