Latex template visual improvements #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The equipment box on the MSavage latex template still quite easily overflows. Previously, this was in part due to the fact that weight and carrying capacity both occupied a single line in the equipment box. This patch puts weigt and carrying capacity on a single line by displaying it in a smaller font size and by rounding weight to whole numbers instead of two decimals.
This patch prevents the portrait picture in the MSavage latex template to overflow the appearance box. It centers the portrait if it doesn't fill the width of the appearance box. And it keeps compatibility of having both text and an image in the portrait box.
Previously, the MSavage latex template did not scale font size in order to fit text inside specific spaces, which meant that the levels and classes of a multiclass character would overflow the text space for level and class. With the current template, we can list all classes and levels. Best tested with the sorcerer_ranger.py example.
The fillable forms list requirements for every spell. For the latex template, this is a little bit harder because you need to escape the dollar sign $ for valuable components. This patch does exactly that.
The fillable pdf format has overflow sheets for when the number of spells exceeds the number of spells for one spell page. This patch implements such overflow sheets for the latex character sheets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are five patches that together improve the quality of the latex character template and that bring the information on the latex character character sheet at the same level as the fillable sheets (except the proficiencies, but neither form if perfect at this point).
The first patch creates still more room in for equipment by putting weight and carrying capacity on one line instead of two.
The second patch improves portrait handling by better resizing pictures and keeping space for text as well.
The third patch lists all classes and levels on the character sheet, instead of only the primary class and level, just as the fillable sheet.
The fourth patch adds spell components information to the spell sheets, just as the fillable sheets.
The fifth patch introduces overflow spell pages, just as the fillable sheets.
These patches hinge on a recent change in the MSavage latex character sheet that introduces automatic font downsizing to prevent text box overflow. With all this, the latex character sheet is at feature parity with the fillable forms, barring proficiencies. I do have a separate branch for improving how proficiencies are dealt with on both the latex and fillable forms.