Do not feed iterables to Map/Set constructors

canjs · Sep 4, 2018 · d5b1664 · d5b1664
1 parent bc5e545
commit d5b1664
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 9 deletions.
diff --git a/lib/attr.js b/lib/attr.js
@@ -38,8 +38,10 @@ live.attr = function(el, attributeName, compute) {
 		// register that the handler changes the parent element
 		canReflect.assignSymbols(liveUpdateAttr, {
 			"can.getChangesDependencyRecord": function() {
+				var s = new Set();
+				s.add(el);
 				return {
-					valueDependencies: new Set( [ el ] )
+					valueDependencies: s
 				};
 			}
 		});

diff --git a/lib/attrs.js b/lib/attrs.js
@@ -65,8 +65,10 @@ live.attrs = function(el, compute, scope, options) {
 		// register that the handler changes the parent element
 		canReflect.assignSymbols(liveAttrsUpdate, {
 			"can.getChangesDependencyRecord": function() {
+				var s = new Set();
+				s.add(el);
 				return {
-					valueDependencies: new Set( [ el ] )
+					valueDependencies: s
 				};
 			}
 		});

diff --git a/lib/html.js b/lib/html.js
@@ -88,8 +88,10 @@ live.html = function(el, compute, parentNode, nodeListOrOptions) {
 		// register that the handler changes the parent element
 		canReflect.assignSymbols(liveHTMLUpdateHTML, {
 			"can.getChangesDependencyRecord": function() {
+				var s = new Set();
+				s.add(parentNode);
 				return {
-					valueDependencies: new Set( [ parentNode ] )
+					valueDependencies: s
 				};
 			}
 		});

diff --git a/lib/text.js b/lib/text.js
@@ -43,8 +43,10 @@ live.text = function(el, compute, parentNode, nodeList) {
 		// register that the handler changes the parent element
 		canReflect.assignSymbols(liveTextUpdateTextNode, {
 			"can.getChangesDependencyRecord": function() {
+				var s = new Set();
+				s.add(parent);
 				return {
-					valueDependencies: new Set( [ parent ] )
+					valueDependencies: s
 				};
 			}
 		});

diff --git a/test/html-test.js b/test/html-test.js
@@ -92,12 +92,12 @@ test("html live binding handles objects with can.viewInsert symbol", 2, function
 	div.appendChild(placeholder);
 
 	var html = new Observation(function() {
-		return {
-			[canSymbol.for("can.viewInsert")]: function() {
-				assert.equal(arguments[0], options, "options were passed to symbol function");
-				return document.createTextNode("Replaced text");
-			}
+		var d = {};
+		d[canSymbol.for("can.viewInsert")] = function() {
+			assert.equal(arguments[0], options, "options were passed to symbol function");
+			return document.createTextNode("Replaced text");
 		};
+		return d;
 	});
 
 	live.html(placeholder, html, div, options);