Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the implementations of service mocks and doubles #155

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

maxiberta
Copy link
Contributor

Multiple custom implementations of service "mocks" and "doubles" cause confusion and are hard to maintain. The recommended alternative is using the OpenAPI spec with tools such as Connexion.

@maxiberta
Copy link
Contributor Author

Tests are failing due to a compat issue with Werkzeug 3.0, fixed in #154 .

@maxiberta maxiberta marked this pull request as ready for review August 21, 2024 22:07
Copy link

@ebrostrom-canonical ebrostrom-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Maxi! I don't have a ton of background on this but code looks good to me.

@maxiberta maxiberta merged commit c37ceb2 into canonical:main Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants