Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply suggestions from Ben Hoyt's review #5

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Apply suggestions from Ben Hoyt's review #5

merged 2 commits into from
Nov 22, 2023

Conversation

weiiwang01
Copy link
Collaborator

Thanks @benhoyt !

benhoyt
benhoyt approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@benhoyt benhoyt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like good improvements to me, thanks!

Link to my review, for reference.

@weiiwang01 weiiwang01 merged commit 96816de into main Nov 22, 2023
2 checks passed
@weiiwang01 weiiwang01 deleted the feat-refactor branch November 29, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhoyt benhoyt benhoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiiwang01 @benhoyt