Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charm is deducing the executor tag based on the tag of the controller image #115

Closed
kimwnasptd opened this issue Aug 4, 2023 · 1 comment · Fixed by #125
Closed

Charm is deducing the executor tag based on the tag of the controller image #115

kimwnasptd opened this issue Aug 4, 2023 · 1 comment · Fixed by #125
Labels
bug Something isn't working

Comments

@kimwnasptd
Copy link
Contributor

The Charm is deducing what executor image to use based on the tag of the controller image. This is error prone and expects a specific tagging for both images.

We should instead have this whole image configurable, via the config.yaml file. This also limits our airgapped story, since we can't define a different registry for the image.

argo-operators/charms/argo-controller/src/charm.py

Lines 82 to 85 in 0d80f2a

# Sync the argoproj/argoexec image to the same version
metadata = yaml.safe_load(Path("metadata.yaml").read_bytes())
version = metadata["resources"]["oci-image"]["upstream-source"].split(":")[-1]
executor_image = f"argoproj/argoexec:{version}"

@kimwnasptd kimwnasptd added the bug Something isn't working label Aug 4, 2023
orfeas-k added a commit that referenced this issue Aug 29, 2023
@orfeas-k
argo-controller: Add executor-image to config
eebdbb9 
Add executor-image field in the charm's config file in order to avoid
deducing it based on the tag of the container image.

Closes #115
@orfeas-k orfeas-k mentioned this issue Aug 29, 2023
Merged
@orfeas-k
Copy link
Contributor

We need to merge this #125 before proceeding with canonical/bundle-kubeflow#680.

orfeas-k added a commit that referenced this issue Aug 29, 2023
@orfeas-k
argo-controller: Add executor-image to config (#125)
3c600d0 
Add executor-image field in the charm's config file in order to avoid deducing it based on the tag of the container image.

Closes #115
i-chvets pushed a commit that referenced this issue Sep 22, 2023
fix: ported exec image config
c6604c8 
Summary of changes:
- Ported configuration of executor image configuration.
- Issue: #115
- PR on main: #125
@i-chvets i-chvets mentioned this issue Sep 22, 2023
Merged
i-chvets added a commit that referenced this issue Sep 22, 2023
@i-chvets
fix: ported exec image config (#135)
92affde 
Summary of changes:
- Ported configuration of executor image configuration.
- Issue: #115
- PR on main: #125
i-chvets added a commit that referenced this issue Sep 27, 2023
@i-chvets
Fix port config exec image (#139)
eaf66b5 
* fix: ported exec image config

Summary of changes:
- Ported configuration of executor image configuration.
- Issue: #115
- PR on main: #125

* fix: updated image with reference to rock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
MLOps Solution Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

argo-controller: Add executor-image to config canonical/argo-operators
2 participants
@kimwnasptd @orfeas-k